This repository has been archived by the owner on Oct 10, 2019. It is now read-only.
Check for iconv() TRANSLIT support #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some iconv() implementations don't support transliteration. When iconv with //TRANSLIT is first attempted and fails, try again without it, and remember the result. Fixes akrennmair#364
Minoru
suggested changes
Sep 29, 2016
| @@ -16,7 +17,7 @@ namespace newsbeuter { | |||
| */ | |||
|
|
|||
| stfl::form::form(const std::string& text) : f(0) { | |||
| ipool = stfl_ipool_create((std::string(nl_langinfo(CODESET)) + "//TRANSLIT").c_str()); | |||
| ipool = stfl_ipool_create(utils::translit(std::string(nl_langinfo(CODESET)), "WCHAR_T").c_str()); | |||
There was a problem hiding this comment.
We can encapsulate some string conversion if we add std::string translit(const char* tocode, const std::string& fromcode).
(There's also final c_str() call, but I suspect this is more tricky due to time of life details. I'll deal with this myself later.)
Minoru
approved these changes
Sep 29, 2016
1 similar comment
|
We don't have any tests for that part of Newsbeuter, so it's a bit early to call it a day. Checklist of things I want to do before merging this:
If both of these checks fail to find any problems, I'm going to merge this PR on Sunday, October 1st. @kobezda, thanks for your work! |
|
Well, my testing didn't find any problems, so hopefully our users won't run into any either. Thanks, @kobezda! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some iconv() implementations don't support transliteration.
When iconv with //TRANSLIT is first attempted and fails,
try again without it, and remember the result.
Fixes #364
Fixes #174