Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start GrafanaClient in prom_ex.dashboard.publish (#127) #152

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

JowiM
Copy link
Contributor

@JowiM JowiM commented Jul 22, 2022

Change description

Added a function to start PromEx.GrafanaClient before calling upload dashboard. When uploading dashboard this will fix the issue where Finch is not found

What problem does this solve?

Issue number: #127

@coveralls
Copy link

coveralls commented Jul 22, 2022

Coverage Status

Coverage decreased (-0.5%) to 79.389% when pulling abc0813 on JowiM:bug/127-grafana-client-not-loaded into abdfd40 on akoutmos:master.

@akoutmos
Copy link
Owner

Thanks for the contribution!

@akoutmos akoutmos merged commit 1ada6a8 into akoutmos:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants