SynchronizationContext for #907 #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have to account for the xUnit synchronizationcontext or is that applied ontop of this one once the async test starts? |
|
Xunit just wraps anything it finds before calling the method, but after calling constructor. |
|
Could we add a test to verify the existence and resolution of the bug in addition to the fix? |
kekekeks
added a commit
to kekekeks/akka.net
that referenced
this pull request
Apr 27, 2015
|
Obsoleted by #913 |
|
CallContext is a slowpoke, so it seems that we are going to use this |
|
As #913 is too costly in terms of processing overhead, we still need this fix. |
rogeralsing
added a commit
that referenced
this pull request
Apr 28, 2015
SynchronizationContext for #907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should restore current actor cell before calling continuation