removed ITellScheduler extensions from F# API #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue with recursive ITellScheduler F# extension call
|
We should add tests for this imo |
|
@rogeralsing @Horusiath does that mean that we need to add them to this PR? Or do you want to create a separate issue for that? |
|
IMO we should at least have a test that proves the broken bits are now fixed for each bug fix PR. |
|
Ok, I'll update PR. |
|
Ok, I've realized it's quite cumbersome without F# support for akka testkit. Can we get this one up (I've tested in localy on some example) and cover tests after TestKit.FSharp plugin will be out? |
|
@Horusiath who's doing the TestKit for FSharp? |
|
Me... eventually. |
rogeralsing
added a commit
that referenced
this pull request
Apr 13, 2015
removed ITellScheduler extensions from F# API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix an #831 issue. New implementations of
ScheduleTellOnceandScheduleTellRepeatedlyare now ripped off from optional parameters - they provide a minimal set of parameters required by their previous versions, while more parametrized ones are still available from akka coreITellSchedulerimplementation.