Obsoleted actor producer pipeline extensions #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,6 +202,7 @@ namespace Akka.Actor | |||
| public override int GetHashCode() { } | |||
| } | |||
| } | |||
| [System.ObsoleteAttribute("Actor producer pipeline API will be removed in v1.5.")] | |||
There was a problem hiding this comment.
Why v1.5? We could remove it in 1.4 or in 1.6. Actually in some next major version
There was a problem hiding this comment.
I think it won't hurt if we give users more time for adoption. I hoped to bring native DI with v1.5, there is no immediate need to close this part of an API before that.
Aaronontheweb
approved these changes
Sep 19, 2017
Horusiath
force-pushed
the
obsoleted-actor-creator-pipeline
branch
from
1347ce9 to
198cad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #3050 and #3057 , if we're going to modernize the way how we do create actors (including native support for dependency injection) an existing actor producer pipeline API will need to be removed - this isn't actually a great pain, as AFAIK it's not a very popular or well-known part of the API.
This PR obsoletes relevant types and fields with Actor producer pipeline API will be removed in v1.5. message, so that eventual users will be informed about this beforehand.