[BENCHMARK] Lazy ChildContainer with full termination sequence #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shutdown method for actors
| let childRestartStats = stat as ChildRestartStats | ||
| where childRestartStats != null | ||
| select childRestartStats.Child).ToList(); | ||
| var children = from stat in InternalChildren.Values |
There was a problem hiding this comment.
it's kinda a personal thing but I find this linq syntax a little meh.
can we just do something like
InternalChildren.Values .OfType<ChildRestartStats>() .Select(stats => stats.Child);
|
I updated PR #1772 to fix the Children.Count that might not have been accurate. I also changed the LINQ queries to make @annymsMthd happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking #1772 in combination with #1765