Implemented StarTime and Uptime #1617
Conversation
| /// <summary> | ||
| /// Returns the time in milliseconds since the epoch | ||
| /// </summary> | ||
| private static long MillisecondsSinceEpoch() |
There was a problem hiding this comment.
Should this maybe moved into Utils?
There was a problem hiding this comment.
You should use the methods we have in the MonotonicClock under utils and see if that suits your needs here. If it doesn't, then yes you should move this into a utility class in that namespace.
Aaronontheweb
added
addressed remarks
reviewed with remarks
and removed
needs review
addressed remarks
labels
marcpiechura
force-pushed
the
Implemented_StartTime_and_Uptime
branch
from
c124c46 to
21a3e22
Compare
|
@Aaronontheweb @rogeralsing updated |
|
LGTM, I'm restarting the multi node tests before merge |
|
I'm going to fix that racy one soon, now that I have better logs |
|
@Silv3rcircl3 this will need to be rebased on dev due to #1639 being merged in. Bear in mind you'll need to run the unit tests locally first to generate a new .approved.txt file per the new process we're using to control how the public API gets modified. I outlined this here: http://getakka.net/docs/akka-developers/public-api-changes Could you give that a try? |
marcpiechura
force-pushed
the
Implemented_StartTime_and_Uptime
branch
2 times, most recently
from
509ca3d to
9fa300c
Compare
| @@ -3765,7 +3767,7 @@ namespace Akka.Routing | |||
| } | |||
| public class DefaultResizer : Akka.Routing.Resizer, System.IEquatable<Akka.Routing.DefaultResizer> | |||
| { | |||
| public DefaultResizer(int lower, int upper, int pressureThreshold = 1, double rampupRate = 0.2, double backoffThreshold = 0.3, double backoffRate = 0.1, int messagesPerResize = 10) { } | |||
| public DefaultResizer(int lower, int upper, int pressureThreshold = 1, double rampupRate = 0,2, double backoffThreshold = 0,3, double backoffRate = 0,1, int messagesPerResize = 10) { } | |||
There was a problem hiding this comment.
The diff marked this also as failure, doesn't know why but have changed it.
|
@Aaronontheweb updated |
|
It's working on my machine 😉 |
marcpiechura
force-pushed
the
Implemented_StartTime_and_Uptime
branch
from
9fa300c to
896134e
Compare
|
Fixed Api approve test. |
…Uptime Implemented StarTime and Uptime
The JVM version has this two properties which I need in the ActorSystemSpec.