Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1499 #1500

Merged
merged 1 commit into from
Dec 8, 2015
Merged

Fix 1499 #1500

merged 1 commit into from
Dec 8, 2015

Conversation

Danthar
Copy link
Member

@Danthar Danthar commented Dec 4, 2015

Instead of simply rethrowing an exception we use
ExceptionDispatchInfo.Capture to preserve the stacktrace. This is an >=
Net 4.5 feature only.

Instead of simply rethrowing an expection we use
ExceptionDispatchInfo.Capture to preserve the stacktrace. This is an  >=
Net 4.5 feature only.
@Danthar
Copy link
Member Author

Danthar commented Dec 4, 2015

I know there has been done some work to support lower versions of .Net. Since this PR for #1499 contains an 4.5 feature. We might want to look into alternatives ?

I saw some work is done in regards to backporting I wonder if mono has an implementation for this class, which we might use.

@Danthar
Copy link
Member Author

Danthar commented Dec 4, 2015

It seems mono has its own implementation which is .net 4 compatible. https://github.com/mono/mono/tree/5.7/mcs/class/corlib/System.Runtime.ExceptionServices

@Danthar
Copy link
Member Author

Danthar commented Dec 4, 2015

To be clear. I could use some feedback on this issue regarding which direction we should take.

@Aaronontheweb
Copy link
Member

@Danthar For the time being, I think we use this - so it should still work on Mono 4.+ then?

@Danthar
Copy link
Member Author

Danthar commented Dec 8, 2015

I checked the mono repo. Its been in there for a while 3.* already has it. Only its not until mono 4.0 that the ifdef .net 4.5 got removed. So in short yes it should work on mono 4.

@Aaronontheweb
Copy link
Member

Sounds good - I think in terms of doing whatever we need to do support Unity3D.... not a priority right now. There's plenty of other stuff, like the TPL, they don't have access to that's already heavily used in Akka.NET.

Aaronontheweb added a commit that referenced this pull request Dec 8, 2015
@Aaronontheweb Aaronontheweb merged commit 6b722e4 into akkadotnet:dev Dec 8, 2015
@Danthar Danthar deleted the fix-1499 branch February 11, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants