Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DotNettyTransport #1465

Closed

Conversation

Aaronontheweb
Copy link
Member

No description provided.

@Aaronontheweb
Copy link
Member Author

Haven't removed Helios yet - wanted to collect some data from the build server.

Note: this is going into a separate version branch independent of dev because the DotNettyTransport is going to need to be part of a minor version release due to breaking changes with the existing HeliosTcpTransport. I might be able to eliminate those with a little finagling inside Helios but I can't confirm yet.

@annymsMthd
Copy link
Contributor

I'll check this out when I get to work
On Tue, Nov 24, 2015 at 8:06 PM Aaron Stannard notifications@github.com
wrote:

Haven't removed Helios yet - wanted to collect some data from the build
server.

Note: this is going into a separate version branch independent of dev
because the DotNettyTransport is going to need to be part of a minor
version release due to breaking changes with the existing
HeliosTcpTransport. I might be able to eliminate those with a little
finagling inside Helios but I can't confirm yet.


Reply to this email directly or view it on GitHub
#1465 (comment).

@Aaronontheweb
Copy link
Member Author

Looks like I introduced a bug inside GracefulStop, and the stress test revealed some initialization issues with the transport. Failure to block reads probably.

@Aaronontheweb
Copy link
Member Author

Hey @maxim-s, @alexpantyukhin told me that you want to take on reviewing this one. Message me if you need any help with the DotNetty part of it.

@Aaronontheweb
Copy link
Member Author

@bobanco is someone else who could help review this - I know he knows DotNetty well.

@bobanco
Copy link

bobanco commented Dec 2, 2015

@Aaronontheweb i will take a look trough this weekend, am pretty busy these days.

@maxim-s
Copy link
Contributor

maxim-s commented Dec 12, 2015

looks good

@Aaronontheweb Aaronontheweb force-pushed the dotnetty-integration-rebase branch from b7ee065 to df83f80 Compare January 12, 2016 02:47
@Aaronontheweb Aaronontheweb force-pushed the dotnetty-integration-rebase branch from df83f80 to 1632d74 Compare January 19, 2016 23:18
@JeffCyr
Copy link
Contributor

JeffCyr commented Mar 4, 2016

The Throughput test in this code is not working with the DotNetty transport
https://github.com/JeffCyr/Akka.Remote.Transport.Streams/blob/dev/src/StreamTransportSample/Program.cs

The latency test is working so something is probably breaking when there is concurrent writes on a connection.

@Danthar
Copy link
Member

Danthar commented Sep 20, 2016

Whats the status of this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants