Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect ordering with UnboundedPriorityMailbox #881

Closed
nvivo opened this issue Apr 21, 2015 · 2 comments
Closed

Incorrect ordering with UnboundedPriorityMailbox #881

nvivo opened this issue Apr 21, 2015 · 2 comments

Comments

@nvivo
Copy link
Contributor

nvivo commented Apr 21, 2015

There is a small bug in ListPriorityQueue that causes invalid ordering. This is caused by passing the entire envelope instead of the message to the priorityGenerator here

Bug sample:
https://dotnetfiddle.net/YnHR3e

I'll provide a PR for this.
nvivo added a commit to nvivo/akka.net that referenced this issue Apr 21, 2015
@nvivo
Fixes ordering issues with the priority mailbox. Resolves akkadotnet#881
323b111
@Aaronontheweb
Copy link
Member

@nvivo do you think this is something we should add to our test coverage?

rogeralsing added a commit that referenced this issue Apr 21, 2015
@rogeralsing
Merge pull request #882 from nvivo/priority-mailbox-fix
1ce7b0a 
Fixes ordering issues with the priority mailbox. Resolves #881
@nvivo nvivo mentioned this issue Apr 21, 2015
Merged
@nvivo
Copy link
Contributor Author

nvivo commented Apr 21, 2015

@Aaronontheweb added some tests on a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nvivo @Aaronontheweb