Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace not preserved when unhandled exception gets sent to a Supervisor strategy #1501

Closed
stevemesser opened this issue Dec 4, 2015 · 2 comments

Comments

@stevemesser
Copy link

I did a quick look at the source and I found at least one exception throwing problem.

First I am not a JVM guy but with the little research I did I found out that the JVM and .NET handle the throwing and rethrowing of exceptions opposite of each other.

http://www.tkachenko.com/blog/archives/000352.html

private void HandleFailed(Failed f) //Called handleFailure in Akka JVM
{
     if (statsUid == f.Uid)
     {
         var handled = _actor.SupervisorStrategyInternal.HandleFailure(this, f.Cause, childStats,   ChildrenContainer.Stats);
         if (!handled)
              throw f.Cause; // This is probably at least one of the culprits
     }
}

You probably want to look into ExceptionDispatchInfo.Capture(...).Throw() as it maintains the stack trace

@Danthar
Copy link
Member

Danthar commented Dec 4, 2015

Duplicate of #1499

@Danthar Danthar closed this as completed Dec 4, 2015
@stevemesser
Copy link
Author

They should be combined if possible. Mine has some background info
On Dec 4, 2015 8:52 AM, "Arjen Smits" notifications@github.com wrote:

Duplicate of #1499 #1499


Reply to this email directly or view it on GitHub
#1501 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants