Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionalSource #84

Merged
merged 5 commits into from
Nov 12, 2019

Conversation

IgorFedchenko
Copy link
Contributor

@IgorFedchenko IgorFedchenko commented Oct 29, 2019

As next part of work for issue #36 , this PR is going to implement TransactionalSource, TransactionalSink and TransactionalFlow.

First of them is already implemented, but it can not be tested and used without one of the transactional producer stages. TransactionalSink as a simple wrapper over TransactionalFlow, and both of them are used in tests for TransactionalSource. So, all three are going to be implemented in this PR to make CI checks useful.

Update: Only TransactionalSource will be implemented here, and producer related code with tests will be in next PR.

@IgorFedchenko IgorFedchenko changed the title TransactionalStages Transactional stages Oct 29, 2019
@IgorFedchenko
Copy link
Contributor Author

Ah, I see now that producers implementation depends on #83 PR which is on review now. But currently implemented TransactionalSource does not depend on it, so let me make this PR ready for review without tests - it will be tested in another PR, which will make use if this one and #83.

@IgorFedchenko IgorFedchenko changed the title Transactional stages TransactionalSource Oct 29, 2019
@IgorFedchenko IgorFedchenko marked this pull request as ready for review October 29, 2019 14:17
@Aaronontheweb Aaronontheweb merged commit 89c05dc into akkadotnet:dev Nov 12, 2019
@IgorFedchenko IgorFedchenko deleted the transactional_stages branch November 15, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants