PlainPartitionedWithOffset source #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Aaronontheweb
approved these changes
Oct 15, 2019
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Akka.Streams.Kafka.Tests.Integration |
| /// When a topic-partition is assigned to a consumer, the <see cref="getOffsetsOnAssign"/> | ||
| /// function will be called to retrieve the offset, followed by a seek to the correct spot in the partition. | ||
| /// | ||
| /// The <see cref="onRevoke"/> function gives the consumer a chance to store any uncommitted offsets, and do any other cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more PR related to #36 , implements
PlainPartitionedWithOffsetsource.This one is pretty simple, because reuses
SubSourceStageimplemented forPlainPartitionedSource, but passes initial offsets to start from.