-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SourceWithOffsetContext #62
SourceWithOffsetContext #62
Conversation
@IgorFedchenko have some merge conflicts here |
Yes, each of my PRs adds new extension method to KafkaConsumer.cs file, so seems like we will have conflicts on each merge... |
@IgorFedchenko ah, ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but have some questions
After updating committer default settings in |
As a part of work over issue #36 ,
SourceWithOffsetContext
consumer source will be implemented and tested in this PR.This souse is basically provides another way of passing consumed messages and committable offset to downstream. The main difference (as far as I understand) is that while
CommittableSource
passesCommittableMessage
to the downstream, forcing consequent flows to handle both message and it's committable offset, thisSourceWithOffsetContext
allows to put committable offset to the source's context.Also, some helpers like
Committer
static class with committing flows are implemented in this PR, because they are used to make testing simpler/cleaner.There is one more test for this source type, but it will require one more producer flow implementation, so it will be added in one of the next PRs.