Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionAssignmentHandler: add onLost #986

Merged
merged 5 commits into from
Nov 30, 2019
Merged

PartitionAssignmentHandler: add onLost #986

merged 5 commits into from
Nov 30, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 26, 2019

Purpose

Propagate the ConsumerRebalanceListener.onPartitionsLost introduced in the Kafka 2.4.0 client to Alpakka Kafka's PartitionAssignementHandler.

References

References #982

Changes

@ennru ennru added this to the 2.0.0 milestone Nov 26, 2019
seglo
seglo reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some reading on onPartitionsLost and I think we should update the docs.

https://cwiki.apache.org/confluence/display/KAFKA/KIP-429%3A+Kafka+Consumer+Incremental+Rebalance+Protocol

core/src/main/scala/akka/kafka/javadsl/PartitionAssignmentHandler.scala Outdated Show resolved Hide resolved
core/src/main/scala/akka/kafka/scaladsl/PartitionAssignmentHandler.scala Outdated Show resolved Hide resolved
core/src/main/scala/akka/kafka/javadsl/PartitionAssignmentHandler.scala Outdated Show resolved Hide resolved
core/src/main/scala/akka/kafka/scaladsl/PartitionAssignmentHandler.scala Outdated Show resolved Hide resolved
docs/src/main/paradox/consumer-rebalance.md Outdated Show resolved Hide resolved
seglo
seglo approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo force-pushed the rebalance-handler-onLost branch from 99bacfb to 33b70a6 Compare November 29, 2019 19:11
@seglo seglo merged commit f741caa into akka:master Nov 30, 2019
@ennru ennru mentioned this pull request Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
core documentation tests
Projects
None yet
Milestone
2.0.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @seglo