Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt 1.3.5 #926

Merged
merged 1 commit into from
Dec 19, 2019
Merged

sbt 1.3.5 #926

merged 1 commit into from
Dec 19, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 8, 2019

Use sbt 1.3.2 in the build and adapt caching directories in Travis.

@ennru
Copy link
Member Author

ennru commented Oct 10, 2019

After restarting a few build steps for strange lock errors everything went through, but the docker-compose testing seems broken. It could be the exclusions I added.

[info] akka.kafka.PartitionedSourceFailoverSpec *** ABORTED *** (30 milliseconds)
[info]   java.lang.NoClassDefFoundError: org/glassfish/hk2/api/MultiException
[info]   at akka.kafka.PartitionedSourceFailoverSpec.<init>(PartitionedSourceFailoverSpec.scala:30)

@ennru ennru changed the title sbt 1.3.2 sbt 1.3.3 Oct 16, 2019
@seglo
Copy link
Contributor

seglo commented Oct 16, 2019

Looks like the mima plugin is reporting new problems for some reason.

@ennru
Copy link
Member Author

ennru commented Oct 16, 2019

The new version of MiMa discovers the change in generics on flowWithOffsetContext from #931

@ennru ennru force-pushed the sbt-1.3.2 branch 2 times, most recently from 9cafbb1 to e971485 Compare October 18, 2019 06:52
@ennru
Copy link
Member Author

ennru commented Oct 18, 2019

The integration tests still fail for a missing class. I need to revisit the dependency exclusions.

@ennru
Copy link
Member Author

ennru commented Oct 18, 2019

The test run further this time but failed for another missing class

[info]   Cause: java.lang.IllegalStateException: InjectionManagerFactory not found.
[info]   at org.glassfish.jersey.internal.inject.Injections.lambda$lookupInjectionManagerFactory$0(Injections.java:98)

https://travis-ci.org/akka/alpakka-kafka/jobs/599684381#L3634

For some reason, the transitive dependencies of the "docker-client" library are not added automatically by coursier.

With the work in #939 we might be able to do this testing without the "docker-client", so let's wait for that.

@ennru
Copy link
Member Author

ennru commented Nov 25, 2019

With sbt 1.3.4 the Dependency Graph works again. This is good to go, I think.

@ennru
Copy link
Member Author

ennru commented Nov 25, 2019

Failure is #611

@ennru
Copy link
Member Author

ennru commented Nov 26, 2019

The terminal colours are lost here, as well.

@ennru ennru changed the title sbt 1.3.3 sbt 1.3.4 Nov 27, 2019
@ennru ennru changed the title sbt 1.3.4 sbt 1.3.5 Dec 16, 2019
@ennru
Copy link
Member Author

ennru commented Dec 16, 2019

This looks like a regression in sbt https://travis-ci.org/akka/alpakka-kafka/jobs/625607995#L1065

@ennru
Copy link
Member Author

ennru commented Dec 16, 2019

- Add explicit Kafka dependency as resolution fails for Scala 2.11
- Add color always
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit a942d00 into akka:master Dec 19, 2019
@ennru ennru deleted the sbt-1.3.2 branch December 19, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants