-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaConsumerActor: don't use deprecated KafkaConsumer#committed method #1071
KafkaConsumerActor: don't use deprecated KafkaConsumer#committed method #1071
Conversation
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
Thank you for suggesting this. Yes, please suggest a binary- and preferably source-compatible API. |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
@ennru I kept source compatibility but I still marked some parts as deprecated. Should I remove the test which uses the deprecated code, or there's a way to suppress that error? On the other hand, I'm not sure if I have to use |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
You may change the test to not use the now deprecated API. |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
Before looking into this more closely, we need you to sign the CLA. |
I confirmed the CLA via github, do I need to also send you a scanned and signed copy of it? |
The problem is that the ID in your commits does not match your GitHub user. Usually it's because the email is different. You could update your email id and rewrite the commits, or recreate the PR. |
Ok, I created a new PR: #1073 |
Stop using deprecated KafkaConsumer#committed method, and start using its replacement. This allows to use a set of partitions in a single call, which has better performance than iterating on the old deprecated method.