Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaConsumerActor: don't use deprecated KafkaConsumer#committed method #1071

Closed

Conversation

epalace
Copy link

@epalace epalace commented Mar 2, 2020

Stop using deprecated KafkaConsumer#committed method, and start using its replacement. This allows to use a set of partitions in a single call, which has better performance than iterating on the old deprecated method.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@epalace epalace changed the title KafkaConsumerActor: don't use deprecated consumer.committed method KafkaConsumerActor: don't use deprecated KafkaConsumer#committed method Mar 2, 2020
@ennru
Copy link
Member

ennru commented Mar 2, 2020

Thank you for suggesting this.

Yes, please suggest a binary- and preferably source-compatible API.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@epalace
Copy link
Author

epalace commented Mar 3, 2020

@ennru I kept source compatibility but I still marked some parts as deprecated. Should I remove the test which uses the deprecated code, or there's a way to suppress that error?

On the other hand, I'm not sure if I have to use since = '2.0.3'

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@ennru
Copy link
Member

ennru commented Mar 3, 2020

You may change the test to not use the now deprecated API.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@ennru
Copy link
Member

ennru commented Mar 3, 2020

Before looking into this more closely, we need you to sign the CLA.

@epalace
Copy link
Author

epalace commented Mar 3, 2020

I confirmed the CLA via github, do I need to also send you a scanned and signed copy of it?

@seglo
Copy link
Contributor

seglo commented Mar 3, 2020

I confirmed the CLA via github, do I need to also send you a scanned and signed copy of it?

The problem is that the ID in your commits does not match your GitHub user. Usually it's because the email is different. You could update your email id and rewrite the commits, or recreate the PR.

https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user

@epalace
Copy link
Author

epalace commented Mar 3, 2020

Ok, I created a new PR: #1073

@epalace epalace closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants