Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for Metadata requests #497

Closed
ennru opened this issue Jun 7, 2018 · 5 comments
Closed

Add wrapper for Metadata requests #497

ennru opened this issue Jun 7, 2018 · 5 comments
Milestone

Comments

@ennru
Copy link
Member

ennru commented Jun 7, 2018

The new feature to request Kafka Metadata from the internal KafkaConsumerActor (see #491) would be even nicer with thin wrappers (javadsl and scaladsl) hiding the ask calls and mapping to the correct response types.

@2m 2m added the enhancement label Jul 11, 2018
@2m
Copy link
Contributor

2m commented Jul 11, 2018

The wrapper should also have Scala and Java DSLs with appropriate conversions between Java and Scala types and collections.

@jewertow
Copy link
Contributor

jewertow commented Sep 3, 2019

I will take care of it.

@jewertow
Copy link
Contributor

jewertow commented Sep 6, 2019

I started working on it but I wonder what return types do expect from the wrapper, e.g. in the case of EndOffsets the wrapper should return Future[Long] or Future[Option[Long]]?

@ennru
Copy link
Member Author

ennru commented Sep 6, 2019

With the current GetEndOffsets(Set[TopicPartition]) the response is EndOffsets(Map[TopicPartition, Long]). So I'd expect Future[Map[TopicPartition, Long]].

jewertow added a commit to jewertow/alpakka-kafka that referenced this issue Sep 8, 2019
@ennru ennru added this to the 2.0.0 milestone Nov 27, 2019
@ennru
Copy link
Member Author

ennru commented Nov 27, 2019

Implemented in #497 by @jewertow

@ennru ennru closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants