Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommittingProducerSink: Fix count on failure #1043

Conversation

gabrielreid
Copy link
Contributor

Correct the updating of the count of outstanding produce requests
when a producer failure occurs in CommittingProducerSinkStage.

References #1042

Correct the updating of the count of outstanding produce requests
when a producer failure occurs in CommittingProducerSinkStage.
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let @ennru have final say.

@seglo seglo requested a review from ennru February 6, 2020 17:29
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Fix count of outstanding produce requests (#1042) CommittingProducerSink: Fix count on failure Feb 9, 2020
@ennru ennru merged commit a3a7940 into akka:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants