Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect bookkeeping of outstanding produce requests on produce failures #1042

Closed
gabrielreid opened this issue Feb 6, 2020 · 1 comment
Milestone

Comments

@gabrielreid
Copy link
Contributor

Versions used

alpakka-kafka 2.0.1

Expected Behavior

When an alternative supervision strategy is used with Producer.committableSink, a producer failure should just be ignored and not have further impact on the behavior of the stream (i.e. the stream should still commit outstanding offsets when stopped).

Actual Behavior

The internal bookkeeping for the number of outstanding produce requests is not correctly updated on a Producer failure. This results in no automatic commit occurring when the source of the stream completes, meaning the stream will stay open until a time-based commit occurs (which could be a very long time, depending on the commit settings)

I noticed this while going through related code while investigating the cause of #1040

I'll add a PR with a test that demonstrates the failure and a fix.

gabrielreid pushed a commit to gabrielreid/alpakka-kafka that referenced this issue Feb 6, 2020
Correct the updating of the count of outstanding produce requests
when a producer failure occurs in CommittingProducerSinkStage.
@ennru ennru added this to the 2.0.2 milestone Feb 9, 2020
@ennru
Copy link
Member

ennru commented Feb 9, 2020

Fixed with #1043

@ennru ennru closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants