This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with two minor things
1. In terminal 4: | ||
* To add a thumbs-up for resource `akka` from user `u1` in DC `eu-west`: `curl -X POST http://0.0.0.0:22551/thumbs-up/akka/u1` | ||
* To add a thumbs-up for resource `akka` from user `u2` in DC `eu-west`: `curl -X POST http://0.0.0.0:22552/thumbs-up/akka/u2` | ||
* To get the users that gave thumbs-up for resource `akka`: `curl http://0.0.0.0:22552/thumbs-up/akka` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl to 0.0.0.0
, does that really work? Would 127.0.0.1
be safer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, but 127.0.0.1 is better
|
||
speculative-replication.enabled = off | ||
|
||
// cross-reading-replication { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a first comment saying why this is commented out?
unrelated: #51 |
johanandren
pushed a commit
that referenced
this pull request
Feb 19, 2018
* Sample for Multi-DC Persistence * sharding, cassandra, http, protobuf * translated to java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO before merging: