-
Notifications
You must be signed in to change notification settings - Fork 443
adding akka diagnostics and some cleansing #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, feel free to cut the diagnostics M3 to unlock these sample PRs
Did you try running some of them?
I did not run any of them. I was waiting to release the M3. I was wondering if only run a few or run them all. I was more inclined toward the latter. |
Probably no need to run all, but pick a few. Those with most dependencies are more important. |
akka-sample-cluster-java/build.sbt
Outdated
val AkkaVersion = "2.7.0" | ||
val AkkaDiagnosticsVersion = "2.0.0-M3" | ||
val LogbackClassicVersion = "1.2.11" | ||
val ScalaTestVersion = "3.0.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing in several places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"3.0.8"
was the previous version in the build.sbt (in most build.sbt). Are you suggesting bumping it to 3.1.0
in all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, while you are anyway changing it you can bump to 3.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one project with '3.1.1' I'll use that for the rest.
I checked it in quite a few projects. In a couple of them I found some unrelated issues that I raised in a separate issue. |
I checked it works in quite a few projects: all good. No warning about the conf and no errors. In a couple of them I found some unrelated issues that I raised in a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
References akka/akka-diagnostics#19
Kept in draft until akka-diagnostics 2.0.0-M3 release