Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: akka-grpc samples to 2.3.4 #986

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

<akka-grpc.version>2.3.3</akka-grpc.version>
<akka-grpc-maven-plugin.version>2.3.3</akka-grpc-maven-plugin.version>
<akka-grpc.version>2.3.4</akka-grpc.version>
<akka-grpc-maven-plugin.version>2.3.4</akka-grpc-maven-plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with the bom here, I'd rather keep them in sync. You could just skip the pom.xml files for now.

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more Scala/sbt samples than two, iot-service-scala, shopping-cart-service-scala and shopping-cart-analytics-service-scala, also another one under the replicated directory shopping-cart-service-scala.

@johanandren johanandren merged commit 0f66ca6 into main Sep 4, 2023
@johanandren johanandren deleted the bump-akka-grpc-samples branch September 4, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants