Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Java restaurant deliveries #977

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Aug 30, 2023

No description provided.

}

# FIXME disabled until we have fixed handling of FilteredEvents for publishing in r2dbc
journal.publish-events = off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still a problem? but maybe we'll go over all FIXME in a separate scan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed but I don't think I ever did a milestone release of the R2DBC plugin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll do a follow up work through taking care of FIXMEs

@johanandren johanandren force-pushed the wip-restaurant-drone-deliveries-java branch from ea4aeb4 to af4873a Compare August 31, 2023 11:07
@johanandren johanandren force-pushed the wip-restaurant-drone-deliveries-java branch from af4873a to 86260de Compare August 31, 2023 11:09
@johanandren johanandren marked this pull request as ready for review August 31, 2023 11:37
@johanandren johanandren changed the title docs: Java restaurant deliveries (almost working) docs: Java restaurant deliveries Aug 31, 2023
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit e996466 into main Sep 1, 2023
@patriknw patriknw deleted the wip-restaurant-drone-deliveries-java branch September 1, 2023 07:00
@patriknw patriknw added this to the 1.5.0-M4 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants