-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Java restaurant deliveries #977
Conversation
samples/grpc/restaurant-drone-deliveries-service-java/src/main/resources/persistence.conf
Outdated
Show resolved
Hide resolved
samples/grpc/restaurant-drone-deliveries-service-java/src/main/resources/application.conf
Outdated
Show resolved
Hide resolved
} | ||
|
||
# FIXME disabled until we have fixed handling of FilteredEvents for publishing in r2dbc | ||
journal.publish-events = off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still a problem? but maybe we'll go over all FIXME in a separate scan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed but I don't think I ever did a milestone release of the R2DBC plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll do a follow up work through taking care of FIXMEs
ea4aeb4
to
af4873a
Compare
af4873a
to
86260de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.