Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snapshot as starting point for replay #933

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

patriknw
Copy link
Member

  • the lazy replay requests in Projections over gRPC can start from snapshots to reduce number of events to load and transfer

On top of #929

See akka/akka-persistence-r2dbc#412

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good

@patriknw patriknw force-pushed the wip-start-snapshot-patriknw branch from 468fced to 8e94eab Compare July 3, 2023 13:14
Base automatically changed from wip-start-snapshot-patriknw to main July 4, 2023 05:57
* the lazy replay requests in Projections over gRPC can
  start from snapshots to reduce number of events to load
  and transfer
@patriknw patriknw force-pushed the wip-replay-snapshot-patriknw branch from 551b6c5 to d74b515 Compare July 4, 2023 05:59
@patriknw patriknw marked this pull request as ready for review July 4, 2023 06:00
@patriknw
Copy link
Member Author

patriknw commented Jul 4, 2023

Ready for final review

@patriknw patriknw requested a review from johanandren July 4, 2023 14:10
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 01b6aa5 into main Jul 4, 2023
@johanandren johanandren deleted the wip-replay-snapshot-patriknw branch July 4, 2023 18:14
@johanandren johanandren added this to the 1.5.0-M1 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants