Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ApiMayChange and event type param for producerFilter #847

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Apr 6, 2023

No description provided.

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato
Copy link
Member

octonato commented Apr 6, 2023

[error] /home/runner/work/akka-projection/akka-projection/akka-projection-grpc-tests/src/it/scala/akka/projection/grpc/producer/ProducerFilterEndToEndSpec.scala:139:26: missing parameter type
[error]         producerFilter = envelope => envelope.tags.contains("replicate-it"))

Compilation error in spec.

@johanandren johanandren merged commit aaf1027 into dev-filter Apr 12, 2023
@johanandren johanandren deleted the wip-apimaychange-patriknw branch April 12, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants