fix: Don't trigger replay for duplicates #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Mar 30, 2023
patriknw
commented
- duplicates, less seqNr, have been processed and shouldn't trigger replay
- need more details from R2dbcOffsetStore.isAccepted so changed return value to adt
* duplicates, less seqNr, have been processed and shouldn't trigger replay * need more details from R2dbcOffsetStore.isAccepted so changed return value to adt
patriknw
force-pushed
the
wip-replay-duplicate-patriknw
branch
from
1eebb60 to
9df4661
Compare
octonato
approved these changes
Apr 3, 2023
Comment on lines
+173
to
+177
| object IsAcceptedResult { | ||
| case object Accepted extends IsAcceptedResult | ||
| case object Duplicate extends IsAcceptedResult | ||
| case object RejectedSeqNr extends IsAcceptedResult | ||
| case object RejectedBacktrackingSeqNr extends IsAcceptedResult |
There was a problem hiding this comment.
I find it confusing that the trait is called IsAcceptedResult, but it can be a rejection as well.
Maybe better to call is Validation instead?
object Validation {
case object Accepted extends Validation
case object Duplicate extends Validation
case object RejectedSeqNr extends Validation
case object RejectedBacktrackingSeqNr extends ValidationThere was a problem hiding this comment.
alright, I'll follow up with some renaming in separate PR
| @@ -656,14 +672,17 @@ private[projection] class R2dbcOffsetStore( | |||
| * Completed with `true` if accepted, otherwise `false` if rejected or failed with `EnvelopeRejected` if | |||
| * backtracking envelope is rejected. | |||
| */ | |||
| def isAccepted[Envelope](envelope: Envelope): Future[Boolean] = { | |||
| def isAccepted[Envelope](envelope: Envelope): Future[IsAcceptedResult] = { | |||
There was a problem hiding this comment.
Following previous comment...
def validate[Envelope](envelope: Envelope): Future[Validation]Also, scaladoc needs to be adapted. Not a boolean anymore.
|
test failures are in unrelated modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.