feat: Replay events via IncludeEntityIds request #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Mar 21, 2023
| log.debug("Stream [{}]: tryPullReplay entityId [{}}]", logPrefix, entityId) | ||
| implicit val ec: ExecutionContext = materializer.executionContext | ||
| val next = replayInProgress(entityId).pull().map(ReplayEnvelope(entityId, _)) | ||
| next.onComplete(replayCallback.invoke) |
There was a problem hiding this comment.
The usual optimisation with no invoke if it was already there and future is completed?
|
|
||
| case StreamIn(other, _) => | ||
| log.warning("Unknown StreamIn request [{}]", other.getClass.getName) | ||
| log.warning("Stream [{}]: Unknown StreamIn request [{}]", logPrefix, other.getClass.getName) |
There was a problem hiding this comment.
Should this be a crash maybe even, if we add protocol that isn't supported it could be too important to drop.
There was a problem hiding this comment.
Um, I'm not sure. Could it be good to ignore instead of failing for update scenarios where the versions are not in sync and we add new messages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.