Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Akka 2.8.0 #807

Merged
merged 1 commit into from
Mar 17, 2023
Merged

bump: Akka 2.8.0 #807

merged 1 commit into from
Mar 17, 2023

Conversation

johanandren
Copy link
Member

No description provided.

@@ -27,7 +27,7 @@ run / javaOptions ++= sys.props
.fold(Seq.empty[String])(res => Seq(s"-Dconfig.resource=$res"))
Global / cancelable := false // ctrl-c

val AkkaVersion = sys.props.getOrElse("akka.version", "2.8.0-M4")
val AkkaVersion = sys.props.getOrElse("akka.version", "2.8.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about other samples/grpc ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those already work with 2.7.0/projections 1.3.1 so no real need to bump until we release projections 1.4.0 I think (also tricky because Java ones use the bom).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I agree

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 9323332 into main Mar 17, 2023
@johanandren johanandren deleted the wip-akka-2.8.0-bump branch March 17, 2023 08:16
@johanandren johanandren added this to the 1.4.0 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants