fix: handle adapted java source providers for replay #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, for whatever that's worth :) |
patriknw
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick fix to get replays working for javadsl.
Extending the adapters to cover
LoadEventsByPersistenceIdSourceProvideras well could be better. But adapters are sealed, load events is under event sourced projections, and there would need to be combinations for with or withoutCanTriggerReplay.So just pull out the underlying provider when adapted for now, which implements
LoadEventsByPersistenceIdSourceProvider.We also don't seem to be set up for testing the javadsl currently, so only confirmed manually. Can follow up with tests.