feat: Migration to replicated event sourcing #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
force-pushed
the
wip-es-to-res-patriknw
branch
from
2994503 to
7b6ebad
Compare
|
Completed this with integration tests and reference docs. Ready for final review, but leaving as draft until Akka is released. |
patriknw
force-pushed
the
wip-es-to-res-patriknw
branch
from
7b6ebad to
81b00fd
Compare
patriknw
force-pushed
the
wip-es-to-res-patriknw
branch
from
81b00fd to
2116798
Compare
johanandren
approved these changes
Oct 25, 2024
akka-projection-grpc/src/main/scala/akka/projection/grpc/internal/EventPusher.scala
Show resolved
Hide resolved
| case None => env | ||
| case Some(metadata) => env.withMetadata(metadata) | ||
| } | ||
| } |
There was a problem hiding this comment.
Possible optimization: check if it is the default non-transform and return identity Flow for that as an outer if-else so that it can be cost free when not transforming
johanandren
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires akka/akka#32438
I have tried it with replicated/shopping-cart-service-scala, and I will try to add an integration test.