Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EventWriter snapshot event #1048

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix: EventWriter snapshot event #1048

merged 2 commits into from
Oct 25, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Oct 20, 2023

  • The EventWriter.Write now takes a isSnapshotEvent parameter, which means that sequence number gaps before the snapshot will be filled with filtered event payloads
  • The EventEnvelope.source is "SN" for snapshot events
  • No dependency to akka-persistence-r2dbc from akka-projection-grpc so hardcoding source "SN" (can't use EnvelopeOrigin)

See akka/akka#32191

TODO:

  • update to released Akka version

* The EventWriter.Write now takes a isSnapshotEvent parameter,
  which means that sequence number gaps before the snapshot will
  be filled with filtered event payloads
* The EventEnvelope.source is "SN" for snapshot events
* No dependency to akka-persistence-r2dbc from akka-projection-grpc so
  hardcoding source "SN" (can't use EnvelopeOrigin)
@patriknw patriknw force-pushed the wip-snapshot-patriknw branch from 0d812d9 to 9e2bc2e Compare October 25, 2023 09:00
@patriknw
Copy link
Member Author

Updated to Akka 2.9.0, and that is also done in #1053

@patriknw patriknw marked this pull request as ready for review October 25, 2023 09:01
@patriknw patriknw requested a review from johanandren October 25, 2023 09:01
@patriknw patriknw mentioned this pull request Oct 25, 2023
@patriknw patriknw merged commit bbbbea3 into main Oct 25, 2023
19 checks passed
@patriknw patriknw deleted the wip-snapshot-patriknw branch October 25, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants