Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Local projections starting from snapshots #1047

Merged
merged 5 commits into from
Oct 19, 2023
Merged

feat: Local projections starting from snapshots #1047

merged 5 commits into from
Oct 19, 2023

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Oct 19, 2023 •
edited
Loading

No description provided.

patriknw
patriknw reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good solution, I was looking for if we used EnvelopeOrigin.fromQuery or EnvelopeOrigin.SourceQuery in any places where it should now also consider "SN", but couldn't find any such

@johanandren johanandren marked this pull request as ready for review October 19, 2023 14:03
@johanandren johanandren mentioned this pull request Oct 19, 2023
Merged
patriknw
patriknw approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit bb271d5 into main Oct 19, 2023
19 checks passed
@johanandren johanandren deleted the wip-local-projection-start-from-snapshot branch October 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanandren @patriknw