sample: update native image for clustered local-drone-control-java #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Oct 9, 2023
| @@ -40,6 +40,7 @@ public static final class ReportPosition implements Command { | |||
| public final Position position; | |||
| public final ActorRef<Done> replyTo; | |||
|
|
|||
| @JsonCreator | |||
There was a problem hiding this comment.
not important, but this should only be needed for single arg constructors
There was a problem hiding this comment.
Ah, didn't realise. Just sprinkled when there was a failure for one of the messages. Have updated.
When retesting, discovered that some cross-cluster paths had not been exercised. Another missing CborSerializable and some native image reflect config needed. So that was useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update native image build for local-drone-control-java to support the clustered version and running in kubernetes. And some related small fixes.