chore: Harden drone sample #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Oct 4, 2023
patriknw
commented
- missing CborSerializable in one place
- missing restart supervision, especially important on the delivery queue singleton
- refactoring of config
- application-cluster instead of -kubernetes because we may run single node in kubernetes
* missing CborSerializable in one place * missing restart supervision, especially important on the delivery queue singleton * refactoring of config * application-cluster instead of -kubernetes because we may run single node in kubernetes
* easy way to avoid port conflicts when running more than one locally
|
fyi @pvlugter, some changes here that might overlap with what you have in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.