Generalise for more edge #1009
Merged
Generalise for more edge #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As edge scenarios can have non-database storage, this commit generalises some of those references.
|
Hi @huntc, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
CLA signed. |
johanandren
reviewed
Sep 18, 2023
| with a different file system all previous events will be delivered to the consumer again. | ||
| @@@ |
There was a problem hiding this comment.
Not great with two boxes after each other like this (warning breakout next). Maybe make it just a regular but separate paragraph?
There was a problem hiding this comment.
Resolved in commit 8756757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As edge scenarios can have non-database storage, this commit generalises some of those references.