Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 2.12 build in CI? #822

Closed
patriknw opened this issue Mar 23, 2023 · 1 comment
Closed

Scala 2.12 build in CI? #822

patriknw opened this issue Mar 23, 2023 · 1 comment

Comments

@patriknw
Copy link
Member

We have scala.jdk.CollectionConverters in a few places in akka-projection-grpc. Isn't that for 2.13 and later, and we have to use akka.util.ccompat.JavaConverters._ ? Why isn't this found by CI? We have +IntegrationTest/compile in check-code-compilation
@johanandren
Copy link
Member

For the record: I just did a +publishLocal in the r2db branch without any problems building 2.12 artifacts.

@patriknw patriknw mentioned this issue Mar 27, 2023
Closed
patriknw added a commit that referenced this issue Mar 28, 2023
@patriknw
chore: include akka-projection-grpc-tests in aggregate, #822
6160df2 
* and fix some Scala 2.12 issues
@patriknw patriknw mentioned this issue Mar 28, 2023
Merged
johanandren pushed a commit that referenced this issue Mar 28, 2023
@patriknw
chore: include akka-projection-grpc-tests in aggregate, #822 (#833)
8f34bea 
* and fix some Scala 2.12 issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patriknw @johanandren