Skip to content

Commit

Permalink
perf annotate: Use an array for the disassembler preference
Browse files Browse the repository at this point in the history 
Prior to this change a string was used which could cause issues with
an unrecognized disassembler in symbol__disassembler. Change to
initializing an array of perf_disassembler enum values. If a value
already exists then adding it a second time is ignored to avoid array
out of bounds problems present in the previous code, it also allows a
statically sized array and removes memory allocation needs. Errors in
the disassembler string are reported when the config is parsed during
perf annotate or perf top start up. If the array is uninitialized
after processing the config file the default llvm, capstone then
objdump values are added but without a need to parse a string.

Fixes: a6e8a58 ("perf disasm: Allow configuring what disassemblers to use")
Closes: https://lore.kernel.org/lkml/CAP-5=fUdfCyxmEiTpzS2uumUp3-SyQOseX2xZo81-dQtWXj6vA@mail.gmail.com/
Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20250124043856.1177264-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
  • Loading branch information
@captain5050 @namhyung
captain5050 authored and namhyung committed Jan 27, 2025
1 parent 013eb04 commit bde4ccf
Show file tree
Hide file tree
Showing 3 changed files with 96 additions and 78 deletions.
76 changes: 71 additions & 5 deletions tools/perf/util/annotate.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2100,6 +2100,57 @@ int symbol__annotate2(struct map_symbol *ms, struct evsel *evsel,
return 0;
}

const char * const perf_disassembler__strs[] = {
[PERF_DISASM_UNKNOWN] = "unknown",
[PERF_DISASM_LLVM] = "llvm",
[PERF_DISASM_CAPSTONE] = "capstone",
[PERF_DISASM_OBJDUMP] = "objdump",
};


static void annotation_options__add_disassembler(struct annotation_options *options,
enum perf_disassembler dis)
{
for (u8 i = 0; i < ARRAY_SIZE(options->disassemblers); i++) {
if (options->disassemblers[i] == dis) {
/* Disassembler is already present then don't add again. */
return;
}
if (options->disassemblers[i] == PERF_DISASM_UNKNOWN) {
/* Found a free slot. */
options->disassemblers[i] = dis;
return;
}
}
pr_err("Failed to add disassembler %d\n", dis);
}

static int annotation_options__add_disassemblers_str(struct annotation_options *options,
const char *str)
{
while (str && *str != '\0') {
const char *comma = strchr(str, ',');
int len = comma ? comma - str : (int)strlen(str);
bool match = false;

for (u8 i = 0; i < ARRAY_SIZE(perf_disassembler__strs); i++) {
const char *dis_str = perf_disassembler__strs[i];

if (len == (int)strlen(dis_str) && !strncmp(str, dis_str, len)) {
annotation_options__add_disassembler(options, i);
match = true;
break;
}
}
if (!match) {
pr_err("Invalid disassembler '%.*s'\n", len, str);
return -1;
}
str = comma ? comma + 1 : NULL;
}
return 0;
}

static int annotation__config(const char *var, const char *value, void *data)
{
struct annotation_options *opt = data;
Expand All @@ -2115,11 +2166,10 @@ static int annotation__config(const char *var, const char *value, void *data)
else if (opt->offset_level < ANNOTATION__MIN_OFFSET_LEVEL)
opt->offset_level = ANNOTATION__MIN_OFFSET_LEVEL;
} else if (!strcmp(var, "annotate.disassemblers")) {
opt->disassemblers_str = strdup(value);
if (!opt->disassemblers_str) {
pr_err("Not enough memory for annotate.disassemblers\n");
return -1;
}
int err = annotation_options__add_disassemblers_str(opt, value);

if (err)
return err;
} else if (!strcmp(var, "annotate.hide_src_code")) {
opt->hide_src_code = perf_config_bool("hide_src_code", value);
} else if (!strcmp(var, "annotate.jump_arrows")) {
Expand Down Expand Up @@ -2185,9 +2235,25 @@ void annotation_options__exit(void)
zfree(&annotate_opts.objdump_path);
}

static void annotation_options__default_init_disassemblers(struct annotation_options *options)
{
if (options->disassemblers[0] != PERF_DISASM_UNKNOWN) {
/* Already initialized. */
return;
}
#ifdef HAVE_LIBLLVM_SUPPORT
annotation_options__add_disassembler(options, PERF_DISASM_LLVM);
#endif
#ifdef HAVE_LIBCAPSTONE_SUPPORT
annotation_options__add_disassembler(options, PERF_DISASM_CAPSTONE);
#endif
annotation_options__add_disassembler(options, PERF_DISASM_OBJDUMP);
}

void annotation_config__init(void)
{
perf_config(annotation__config, &annotate_opts);
annotation_options__default_init_disassemblers(&annotate_opts);
}

static unsigned int parse_percent_type(char *str1, char *str2)
Expand Down
15 changes: 10 additions & 5 deletions tools/perf/util/annotate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,13 @@ struct annotated_data_type;
#define ANNOTATION__BR_CNTR_WIDTH 30
#define ANNOTATION_DUMMY_LEN 256

// llvm, capstone, objdump
#define MAX_DISASSEMBLERS 3
enum perf_disassembler {
PERF_DISASM_UNKNOWN = 0,
PERF_DISASM_LLVM,
PERF_DISASM_CAPSTONE,
PERF_DISASM_OBJDUMP,
};
#define MAX_DISASSEMBLERS (PERF_DISASM_OBJDUMP + 1)

struct annotation_options {
bool hide_src_code,
Expand All @@ -52,14 +57,12 @@ struct annotation_options {
annotate_src,
full_addr;
u8 offset_level;
u8 nr_disassemblers;
u8 disassemblers[MAX_DISASSEMBLERS];
int min_pcnt;
int max_lines;
int context;
char *objdump_path;
char *disassembler_style;
const char *disassemblers_str;
const char *disassemblers[MAX_DISASSEMBLERS];
const char *prefix;
const char *prefix_strip;
unsigned int percent_type;
Expand Down Expand Up @@ -134,6 +137,8 @@ struct disasm_line {
struct annotation_line al;
};

extern const char * const perf_disassembler__strs[];

void annotation_line__add(struct annotation_line *al, struct list_head *head);

static inline double annotation_data__percent(struct annotation_data *data,
Expand Down
83 changes: 15 additions & 68 deletions tools/perf/util/disasm.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2216,56 +2216,6 @@ static int symbol__disassemble_objdump(const char *filename, struct symbol *sym,
return err;
}

static int annotation_options__init_disassemblers(struct annotation_options *options)
{
char *disassembler;

if (options->disassemblers_str == NULL) {
const char *default_disassemblers_str =
#ifdef HAVE_LIBLLVM_SUPPORT
"llvm,"
#endif
#ifdef HAVE_LIBCAPSTONE_SUPPORT
"capstone,"
#endif
"objdump";

options->disassemblers_str = strdup(default_disassemblers_str);
if (!options->disassemblers_str)
goto out_enomem;
}

disassembler = strdup(options->disassemblers_str);
if (disassembler == NULL)
goto out_enomem;

while (1) {
char *comma = strchr(disassembler, ',');

if (comma != NULL)
*comma = '\0';

options->disassemblers[options->nr_disassemblers++] = strim(disassembler);

if (comma == NULL)
break;

disassembler = comma + 1;

if (options->nr_disassemblers >= MAX_DISASSEMBLERS) {
pr_debug("annotate.disassemblers can have at most %d entries, ignoring \"%s\"\n",
MAX_DISASSEMBLERS, disassembler);
break;
}
}

return 0;

out_enomem:
pr_err("Not enough memory for annotate.disassemblers\n");
return -1;
}

int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
{
struct annotation_options *options = args->options;
Expand All @@ -2274,7 +2224,6 @@ int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
char symfs_filename[PATH_MAX];
bool delete_extract = false;
struct kcore_extract kce;
const char *disassembler;
bool decomp = false;
int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));

Expand Down Expand Up @@ -2334,28 +2283,26 @@ int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
}
}

err = annotation_options__init_disassemblers(options);
if (err)
goto out_remove_tmp;

err = -1;
for (u8 i = 0; i < ARRAY_SIZE(options->disassemblers) && err != 0; i++) {
enum perf_disassembler dis = options->disassemblers[i];

for (int i = 0; i < options->nr_disassemblers && err != 0; ++i) {
disassembler = options->disassemblers[i];

if (!strcmp(disassembler, "llvm"))
switch (dis) {
case PERF_DISASM_LLVM:
err = symbol__disassemble_llvm(symfs_filename, sym, args);
else if (!strcmp(disassembler, "capstone"))
break;
case PERF_DISASM_CAPSTONE:
err = symbol__disassemble_capstone(symfs_filename, sym, args);
else if (!strcmp(disassembler, "objdump"))
break;
case PERF_DISASM_OBJDUMP:
err = symbol__disassemble_objdump(symfs_filename, sym, args);
else
pr_debug("Unknown disassembler %s, skipping...\n", disassembler);
}

if (err == 0) {
pr_debug("Disassembled with %s\nannotate.disassemblers=%s\n",
disassembler, options->disassemblers_str);
break;
case PERF_DISASM_UNKNOWN: /* End of disassemblers. */
default:
goto out_remove_tmp;
}
if (err == 0)
pr_debug("Disassembled with %s\n", perf_disassembler__strs[dis]);
}
out_remove_tmp:
if (decomp)
Expand Down

0 comments on commit bde4ccf

Please sign in to comment.