Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve עלייה / range display on mobile #138

Open
SLaks opened this issue Oct 23, 2024 · 0 comments
Open

Improve עלייה / range display on mobile #138

SLaks opened this issue Oct 23, 2024 · 0 comments

Comments

@SLaks
Copy link
Contributor

SLaks commented Oct 23, 2024

This is a followup to #129, but I'm not entirely sure what the desired UX should be

At mobile widths, there is no way to see where עליות start and end without swiping to the side. This makes it very hard to scroll through and find an עלייה.

  • We should have some kind of marking (eg, a colored star next to the פסוק label) on a line that has an עלייה marking. Better yet, show 1 through 7 / M instead of a star so you can see which עלייה it is.
  • We should consider rendering a colored vertical line spanning all of the פסוקים in each עלייה (the way Artscroll indicates הפטרות in their תנ״ך, but color-coded). This would be especially helpful for overlapping עליות on ראש חודש or חול המועד סוכות.
  • We should gray out פסוקים that are not part of any run (skips in הפטרות or תעינת ציבור, and the tops and bottoms of עמודים in יום טוב leinings). This requires that we know where in the line each פסוק begins, which we can determine by locating ׃.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant