-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api/v1/accounts/update_credentials
route
#157
Conversation
ff574e9
to
86a7191
Compare
86a7191
to
936c328
Compare
props @akirk Co-authored-by: Alex Kirk <akirk@users.noreply.github.com>
469b926
to
e682a19
Compare
Thanks, this looks great. Amazing that you need to go into multipart decoding to get this to work. I understand this only has editing for a real user on the blog, if we want to do the same for the blog user, we need to find an alternative to the |
@akirk Thanks for looking! I was very grateful to have Claude 3.5 to assist me in understanding what was happening with PATCH requests and how to do my own multipart decoding.
What I've done in Automattic/wordpress-activitypub#788 is to swap over to the Blog User when WP Users are disabled (like on wpcom). Later we can figure out how to let users pick between Blog or User when both are active, but I figured that simply using the User account in that situation should be ok for now. |
Let's merge #160 and then rebase this on main to get rid of some of the phpcs:ignores. |
Nice! Solved some conflicts, I think we're in good shape now! |
d24d3dc
to
5b500e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
This is a bit rough, but it's mostly working along with an ActivityPub plugin PR to enable profile editing from the apps! Automattic/wordpress-activitypub#788