Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api/v1/accounts/update_credentials route #157

Merged
merged 17 commits into from
Aug 1, 2024

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Jun 23, 2024

This is a bit rough, but it's mostly working along with an ActivityPub plugin PR to enable profile editing from the apps! Automattic/wordpress-activitypub#788

@mattwiebe mattwiebe force-pushed the add/profile-route branch from 86a7191 to 936c328 Compare June 24, 2024 03:56
@akirk
Copy link
Owner

akirk commented Jul 9, 2024

Thanks, this looks great. Amazing that you need to go into multipart decoding to get this to work.

I understand this only has editing for a real user on the blog, if we want to do the same for the blog user, we need to find an alternative to the is_user_member_of_blog() call (see Automattic/wordpress-activitypub#800).

@mattwiebe
Copy link
Contributor Author

@akirk Thanks for looking! I was very grateful to have Claude 3.5 to assist me in understanding what was happening with PATCH requests and how to do my own multipart decoding.

I understand this only has editing for a real user on the blog, if we want to do the same for the blog user, we need to find an alternative to the is_user_member_of_blog() call

What I've done in Automattic/wordpress-activitypub#788 is to swap over to the Blog User when WP Users are disabled (like on wpcom). Later we can figure out how to let users pick between Blog or User when both are active, but I figured that simply using the User account in that situation should be ok for now.

@akirk
Copy link
Owner

akirk commented Jul 30, 2024

Let's merge #160 and then rebase this on main to get rid of some of the phpcs:ignores.

@mattwiebe
Copy link
Contributor Author

Let's merge #160 and then rebase this on main to get rid of some of the phpcs:ignores.

Nice! Solved some conflicts, I think we're in good shape now!

@mattwiebe mattwiebe force-pushed the add/profile-route branch from d24d3dc to 5b500e6 Compare July 30, 2024 19:10
Copy link
Owner

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@akirk akirk merged commit eee6b15 into akirk:main Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants