Directly authenticate when building with password #258
+448
−373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a client with
AkeneoPimClientBuilder::buildAuthenticatedByPassword
, the returned client has no access nor refresh tokens. Both corresponding getters will simply returnnull
.For the token to be set, one have to perform at least one API call, so the lower level
AuthenticatedHttpClient::sendRequest()
method tries to get the access token and authenticate if there is none.From an integrator POV, this is confusing, as one would expect to get the tokens right away to store them for future usage.
This PR proposes to call the authentication API when building a client with username and password. This way, the returned client already contains an access token and a refresh token.