Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker env update #353

Merged
merged 1 commit into from
May 25, 2018
Merged

Docker env update #353

merged 1 commit into from
May 25, 2018

Conversation

birkof
Copy link
Contributor

@birkof birkof commented May 22, 2018

  • using mysql 5 latest version
  • single compose file
  • install dependencies through web container

@simpliste
Copy link

I also ran into the mysql problem. The version of Laravel that is used in akounting does not support the latest version of mysql(8).

See: laravel/framework#23948

@birkof
Copy link
Contributor Author

birkof commented May 24, 2018 •
edited
Loading

@simpliste that's why in this PR I made use of mysql:5

@denisdulici
Copy link
Member

Thanks guys. @carvallegro @beinbm any comment?

@beinbm
Copy link

beinbm commented May 25, 2018

i really like the changes! thank you @birkof

@denisdulici denisdulici added this to the 1.2.6 milestone May 25, 2018
@denisdulici denisdulici merged commit eb36b4d into akaunting:master May 25, 2018
@denisdulici
Copy link
Member

Thanks Daniel

@birkof
Copy link
Contributor Author

birkof commented May 25, 2018

Glad I could help 🎉

@denisdulici denisdulici mentioned this pull request Jun 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.2.6
Development

Successfully merging this pull request may close these issues.
5 participants
@birkof @simpliste @denisdulici @beinbm @rodolfovillaruz