Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2330 fixed by removing node 14 #2379

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

jasoniangreen
Copy link
Collaborator

@jasoniangreen jasoniangreen commented Feb 15, 2024

What issue does this pull request resolve?

#2330

What changes did you make?

Removed node 14.x from the build matrix, it has been unsupported for over a year now.

Is there anything that requires more attention while reviewing?

Next steps will be to fix build for node 21.x which @egfx-notifications has kindly provided. We might also want to remove node 16.x as it is out of support now too.

Also @epoberezkin how do we remove this requirement? I think it might be part of github project settings but I wouldn't have access.
Screenshot 2024-02-15 at 22 01 23

@epoberezkin epoberezkin merged commit 3f8b644 into master Feb 16, 2024
4 checks passed
@epoberezkin epoberezkin deleted the fix-build-issue-2330 branch February 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants