Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Bugs and missing checks ensure_acceptable and transfer is locked #346

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

darkfriend77
Copy link
Contributor

@darkfriend77 darkfriend77 commented Sep 3, 2023

Description

This PR addresses the issues in the following tickets:

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@darkfriend77 darkfriend77 requested a review from DidacSF September 3, 2023 07:52
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (7cb3082) 75.82% compared to head (bdba643) 75.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    75.82%   75.85%   +0.02%     
===========================================
  Files           33       33              
  Lines         3454     3458       +4     
===========================================
+ Hits          2619     2623       +4     
  Misses         835      835              
Files Changed Coverage Δ
pallets/ajuna-nft-staking/src/lib.rs 80.26% <100.00%> (+0.26%) ⬆️
pallets/ajuna-nft-transfer/src/lib.rs 82.92% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkfriend77 darkfriend77 changed the title More checks needed ensure_acceptable Bugs and missing checks ensure_acceptable and transfer is locked Sep 3, 2023
Copy link
Contributor Author

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@DidacSF DidacSF merged commit 7d307fe into develop Sep 4, 2023
@DidacSF DidacSF deleted the bugfixes_contract_accept branch September 4, 2023 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants