Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[Staking] Adjusting types of Avatar attributes on NFT conversion #345

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Sep 1, 2023

Description

This PR aims at changing the typing of the NFT attribute in the NFTConvertible interface exposed in the pallet-ajuna-nft-transfer. Many supporting changes have been applied in order for it to work as expected.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@DidacSF DidacSF requested a review from darkfriend77 September 1, 2023 10:30
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 84.84% and project coverage change: +0.01% 🎉

Comparison is base (68b3763) 75.81% compared to head (595d55b) 75.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #345      +/-   ##
===========================================
+ Coverage    75.81%   75.82%   +0.01%     
===========================================
  Files           33       33              
  Lines         3444     3454      +10     
===========================================
+ Hits          2611     2619       +8     
- Misses         833      835       +2     
Files Changed Coverage Δ
pallets/ajuna-awesome-avatars/src/lib.rs 83.04% <ø> (ø)
pallets/ajuna-nft-transfer/src/lib.rs 82.92% <66.66%> (ø)
...lets/ajuna-awesome-avatars/src/types/avatar/nft.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good.

@DidacSF DidacSF force-pushed the ds/adjust-attribute-names branch from 9173fe0 to 595d55b Compare September 1, 2023 12:54
@darkfriend77 darkfriend77 merged commit 7cb3082 into develop Sep 1, 2023
@darkfriend77 darkfriend77 deleted the ds/adjust-attribute-names branch September 1, 2023 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants