This repository has been archived by the owner on May 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the previously generic NFT Attribute in the
nft-staking
pallet, with a fixed type,AttributeValue
. This type has the following signature:This allows flexiblity, since we can have attributes only use on byte of the vec while others may use the full 32 bytes. This also makes it easier to verify the contents and make comparisons between values.
Type of changes
build
: Changes that affect the build system or external dependencies (eg, Cargo, Docker)ci
: Changes to CI configurationdocs
: Changes to documentation onlyfeat
: Changes to add a new featurefix
: Changes to fix a bugrefactor
: Changes that do not alter functionalitystyle
: Changes to format the codetest
: Changes to add missing tests or correct existing testsChecklist
cargo fmt --all
cargo clippy --all-features --all-targets
cargo test --workspace --all-features --all-targets