This repository has been archived by the owner on May 15, 2024. It is now read-only.
Season 2 - Fix forging out of season #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
===========================================
+ Coverage 70.70% 70.72% +0.02%
===========================================
Files 33 33
Lines 3379 3382 +3
===========================================
+ Hits 2389 2392 +3
Misses 990 990
☔ View full report in Codecov by Sentry. |
darkfriend77
approved these changes
Jun 28, 2023
| @@ -1287,7 +1293,7 @@ pub mod pallet { | |||
| .iter() | |||
| .map(|id| { | |||
| let avatar = Self::ensure_ownership(player, id)?; | |||
| ensure!(avatar.season_id == *season_id, Error::<T>::IncorrectAvatarSeason); | |||
| ensure!(avatar.season_id == season_id, Error::<T>::IncorrectAvatarSeason); | |||
| ensure!( | |||
There was a problem hiding this comment.
I would assume this check is not needed since, the encoding of an avatar from the same season must be the same any way since in one season you can only mint one type of encoding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes season_id reference point to be the leader avatar in the forge instead of the current season.
Type of changes
build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)ci: Changes to CI configurationdocs: Changes to documentation onlyfeat: Changes to add a new featurefix: Changes to fix a bugrefactor: Changes that do not alter functionalitystyle: Changes to format the codetest: Changes to add missing tests or correct existing testsChecklist
cargo fmt --allcargo clippy --all-features --all-targetscargo test --workspace --all-features --all-targets