Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Refactoring determine forge type #303

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

darkfriend77
Copy link
Contributor

@darkfriend77 darkfriend77 commented Jun 7, 2023

Description

Please describe your pull request and link relevant issues.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 93.57% and project coverage change: +1.00 🎉

Comparison is base (6e9147a) 70.03% compared to head (743ffd2) 71.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    70.03%   71.03%   +1.00%     
===========================================
  Files           32       32              
  Lines         3190     3145      -45     
===========================================
  Hits          2234     2234              
+ Misses         956      911      -45     
Impacted Files Coverage Δ
...wesome-avatars/src/types/avatar/versions/v2/mod.rs 55.60% <91.95%> (+4.95%) ⬆️
...atars/src/types/avatar/versions/v2/avatar_utils.rs 83.73% <100.00%> (+0.82%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DidacSF DidacSF force-pushed the refactoring_determine_forge_type branch from d7de480 to 743ffd2 Compare June 7, 2023 14:31
@DidacSF DidacSF merged commit 44ecf8f into develop Jun 7, 2023
@DidacSF DidacSF deleted the refactoring_determine_forge_type branch June 7, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants