This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
[PLAT-763], [PLAT-764] Refactor NFT ownership with immutable attributes #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #246 +/- ##
===========================================
- Coverage 77.70% 77.56% -0.15%
===========================================
Files 17 17
Lines 1144 1141 -3
===========================================
- Hits 889 885 -4
- Misses 255 256 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cowboy-bebug
force-pushed
the
el/PLAT-763-nft-ownership-transfer
branch
from
March 28, 2023 20:34
b2992aa
to
d4a7a69
Compare
cowboy-bebug
force-pushed
the
el/PLAT-763-nft-ownership-transfer
branch
from
March 30, 2023 03:23
e4f142b
to
1c8fd6e
Compare
cowboy-bebug
changed the title
[PLAT-763] Refactor NFT transfer ownership
[PLAT-763], [PLAT-764] Refactor NFT ownership with immutable attributes
Mar 30, 2023
* rename all asset -> item * remove nft-staking integration for now * tidy ups
cowboy-bebug
force-pushed
the
el/PLAT-763-nft-ownership-transfer
branch
from
March 30, 2023 04:30
1c8fd6e
to
ed94c47
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re: PLAT-763 & PLAT-764
Main changes:
store_as_nft
:PalletFeature::Attributes
to prevent attribute mutation through thepallet-nfts
extrinsicsNextItemId
and useAvatarId
(H256
) as theItemId
Type of changes
build
: Changes that affect the build system or external dependencies (eg, Cargo, Docker)ci
: Changes to CI configurationdocs
: Changes to documentation onlyfeat
: Changes to add a new featurefix
: Changes to fix a bugrefactor
: Changes that do not alter functionalitystyle
: Changes to format the codetest
: Changes to add missing tests or correct existing testsChecklist
cargo fmt --all
cargo clippy --all-features --all-targets
cargo test --workspace --all-features --all-targets