Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[PLAT-762] Move NFT transfer extrinsics #245

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

cowboy-bebug
Copy link
Contributor

@cowboy-bebug cowboy-bebug commented Mar 28, 2023

Description

RE: PLAT-762

Moving all of the extrinsics from pallet-ajuna-nft-transfer -> pallet-ajuna-awesome-avatars so that we control NFT transfer from the game pallet.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 32.72% and project coverage change: -2.10 ⚠️

Comparison is base (4788e9e) 79.80% compared to head (50e8fe9) 77.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage    79.80%   77.70%   -2.10%     
===========================================
  Files           16       17       +1     
  Lines         1144     1144              
===========================================
- Hits           913      889      -24     
- Misses         231      255      +24     
Impacted Files Coverage Δ
pallets/ajuna-awesome-avatars/src/migration/v1.rs 0.00% <0.00%> (ø)
pallets/ajuna-awesome-avatars/src/migration/v2.rs 0.00% <0.00%> (ø)
pallets/ajuna-awesome-avatars/src/migration/v4.rs 0.00% <0.00%> (ø)
pallets/ajuna-awesome-avatars/src/types/config.rs 63.63% <ø> (ø)
pallets/ajuna-nft-transfer/src/lib.rs 69.35% <0.00%> (-6.61%) ⬇️
pallets/ajuna-nft-transfer/src/traits.rs 100.00% <ø> (ø)
pallets/ajuna-awesome-avatars/src/lib.rs 88.75% <90.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cowboy-bebug cowboy-bebug merged commit 6f5dcbd into develop Mar 28, 2023
@cowboy-bebug cowboy-bebug deleted the el/PLAT-762-move-nft-transfer-ext branch March 28, 2023 02:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant